-
-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tiled background rendering #853
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 7, 2023
* Initial changes for flips * Add EntityDefs integration, add rough visuals * Cleanup, add hotkeys, add cursor display * Cleanup, UI polish. * Fix cover bounds and full size cropped Entity renders * Update pivot display for flipped Entities * docs: Fix hotkey hint in platformer sample (deepnight#821) * Base pivot flipping changes, start visual rollout * Fix issue 826 (deepnight#827) * Revert "Base pivot flipping changes, start visual rollout" This reverts commit 5af2126. * Revert "Update pivot display for flipped Entities" This reverts commit 29ce77a. * Revert broken tile flipping in Repeat mode * Revert errant change to setup.hxml * Final cleanup * Re-add initial pivot flips * Revert "Revert "Update pivot display for flipped Entities"" This reverts commit ae17777. * Add entitydef toggle for flip style, fix placement visual bugs * Make flipped pivots take pivot flipping into account * Fix field display for flipped Entities * Somewhat fix resizing (actual fix in new branch) * Update test-windows.yml * Update test-windows.yml * Entity flips pivots - rebase to dev-1.2.6 (#1) * Fixed reset buttons in field forms * Updated version to 1.2.6 * Changelog * Updated checklist * Cleanup * Added test map * Added comments * Updated test map * Added dummyWorldIid * Updated test map * Updated entities map * Docs * Changelog * Updated lab map * Initial changes for flips * Add EntityDefs integration, add rough visuals * Cleanup, add hotkeys, add cursor display * Cleanup, UI polish. * Fix cover bounds and full size cropped Entity renders * Update pivot display for flipped Entities * Base pivot flipping changes, start visual rollout * Revert "Base pivot flipping changes, start visual rollout" This reverts commit 5af2126. * Revert "Update pivot display for flipped Entities" This reverts commit 29ce77a. * docs: Fix hotkey hint in platformer sample (deepnight#821) * Fix issue 826 (deepnight#827) * Revert broken tile flipping in Repeat mode * Revert errant change to setup.hxml * Final cleanup * Re-add initial pivot flips * Revert "Revert "Update pivot display for flipped Entities"" This reverts commit ae17777. * Add entitydef toggle for flip style, fix placement visual bugs * Make flipped pivots take pivot flipping into account * Fix field display for flipped Entities * Somewhat fix resizing (actual fix in new branch) * Update test-windows.yml * Update test-windows.yml --------- Co-authored-by: Sebastien Benard <[email protected]> Co-authored-by: Johan Klokkhammer Helsing <[email protected]> Co-authored-by: Midyan Hamdoun <[email protected]> * Revert "Entity flips pivots - rebase to dev-1.2.6 (#1)" This reverts commit 59fb849. * Revert changes that should not have been included --------- Co-authored-by: Johan Klokkhammer Helsing <[email protected]> Co-authored-by: Midyan Hamdoun <[email protected]> Co-authored-by: Sebastien Benard <[email protected]>
How the HECK did I merge those into this branch!? Reverting, ugh. |
Merged in 1.3.0 |
Thanks for your PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #852.
Adds a "repeat" option to the "Bg image" field on the "Current Level" tab. Repeat rendering works across all background layer rendering contexts, including exporting to PNGs.
This all works by changing the underlying Bitmap for level backgrounds to a TiledTexture instead and adding some functionality to the TiledTexture in deepnightLibs. Info on that functionality is contained in deepnight/deepnightLibs#45
This does involve a constructor signature change for TiledTexture, which I've applied across LDtk.
This also requires an API change to introduce the Repeat member to the BgImagePos enum: deepnight/ldtk-haxe-api#26
Actions failures stem from mismatching deepnightLibs and LDtk API versions as per the above two PRs.
Images: