Small improvements to unet.UNet, shift.Shift & noise.PoissonNoise #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #137 /- ##
==========================================
Coverage 70.57% 70.59% 0.01%
==========================================
Files 93 93
Lines 6573 6611 38
Branches 894 898 4
==========================================
Hits 4639 4667 28
- Misses 1631 1651 20
Partials 303 293 -10 ☔ View full report in Codecov by Sentry. |
matthieutrs
requested changes
Dec 22, 2023
Co-authored-by: Matthieu Terris <31830373 [email protected]>
tachella
requested changes
Jan 10, 2024
There was a problem hiding this comment.
Sorry for the very late review!
The PR looks good, I just worry that the BFBatchNorm2d module from Mohan et al sometimes produces NaNs during training which causes the whole training procedure to fail.
@Andrewwango did you observe this as well? Maybe there is a solution
tachella
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks to be done before submitting your PR
python3 -m pytest tests/runs successfully.black .runs successfully.make htmlruns successfully (in thedocs/directory).