Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change IDF formula #1141

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Change IDF formula #1141

wants to merge 2 commits into from

Conversation

lmores
Copy link
Contributor

@lmores lmores commented Jan 21, 2023

Implement the change being discussed in #1140.

Also directly import numpy.log to avoid attribute access inside for loop.

@codecov
Copy link

codecov bot commented Jan 21, 2023

Codecov Report

Base: 73.84% // Head: 73.84% // No change to project coverage 👍

Coverage data is based on head (335adc7) compared to base (baa6071).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1141    /-   ##
=======================================
  Coverage   73.84%   73.84%           
=======================================
  Files          28       28           
  Lines        2294     2294           
=======================================
  Hits         1694     1694           
  Misses        600      600           
Impacted Files Coverage Δ
dedupe/canopy_index.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lmores
Copy link
Contributor Author

lmores commented Jan 21, 2023

Experimental verification required.

@lmores lmores closed this Jan 21, 2023
@fgregg
Copy link
Contributor

fgregg commented Jan 21, 2023

@benchmark

@github-actions
Copy link

(logs)

@fgregg
Copy link
Contributor

fgregg commented Jan 21, 2023

it looks like it did maybe improve precision and recall for the restaurant dataset. why don't you re-open this and i can take a look at some other datasets.

@lmores lmores reopened this Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants