Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport 'Fix admin language selector' to v0.28 #12855

Merged
merged 2 commits into from
May 29, 2024
Merged

Backport 'Fix admin language selector' to v0.28 #12855

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift click to select a range
b8fd252
Fix admin language selector
alecslupu May 10, 2024
fbea426
Attempt to fix failing spec
alecslupu May 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions decidim-admin/app/packs/src/decidim/admin/choose_language.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 7,9 @@ export default function initLanguageChangeSelect(elements) {
let targetTabPaneSelector = select.value;
let tabsContent = select.parentElement.parentElement.nextElementSibling;

tabsContent.querySelector(".is-active").ariaHidden = "true";
tabsContent.querySelector(".is-active").classList.remove("is-active");
tabsContent.querySelector(targetTabPaneSelector).ariaHidden = "false";
tabsContent.querySelector(targetTabPaneSelector).classList.add("is-active");
})
});
Expand Down
76 changes: 76 additions & 0 deletions decidim-admin/spec/system/admin_manages_more_locales_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 1,76 @@
# frozen_string_literal: true

require "spec_helper"

describe "Admin language selector" do
let(:admin) { create(:user, :admin, :confirmed, organization:) }
let!(:locales) do
I18n.available_locales = available_locales
Decidim.available_locales = available_locales
end
let(:organization) { create(:organization, available_locales:) }

before do
# Reload the StaticPageForm
Decidim::Admin.send(:remove_const, :StaticPageForm)
load "#{Decidim::Admin::Engine.root}/app/forms/decidim/admin/static_page_form.rb"
switch_to_host(organization.host)
login_as admin, scope: :user
visit decidim_admin.root_path
click_on "Pages"
click_on "Create page"
end

after do
Decidim::Admin.send(:remove_const, :StaticPageForm)
load "#{Decidim::Admin::Engine.root}/app/forms/decidim/admin/static_page_form.rb"
I18n.backend.reload!
end

context "with less than 5 fields" do
let!(:available_locales) do
locales = %w(ro fi en)
I18n.available_locales = locales
Decidim.available_locales = locales
I18n.backend.reload!
locales
end

it "displays Romanian fields" do
expect(page).to have_css("#static_page_title_ro", visible: :hidden)
within "#static_page-title-tabs" do
click_on "Română"
end
expect(page).to have_css("#static_page_title_ro", visible: :visible)
end

it "displays Finnish fields" do
expect(page).to have_css("#static_page_title_fi", visible: :hidden)
within "#static_page-title-tabs" do
click_on "Suomi"
end
expect(page).to have_css("#static_page_title_fi", visible: :visible)
end
end

context "with more than 5 fields" do
let!(:available_locales) do
locales = %w(en ro es ca it fi)
I18n.available_locales = locales
Decidim.available_locales = locales
locales
end

it "displays Romanian fields" do
expect(page).to have_css("#static_page_title_ro", visible: :hidden)
select "Română", from: "static_page-title-tabs"
expect(page).to have_css("#static_page_title_ro", visible: :visible)
end

it "displays Finnish fields" do
expect(page).to have_css("#static_page_title_fi", visible: :hidden)
select "Suomi", from: "static_page-title-tabs"
expect(page).to have_css("#static_page_title_fi", visible: :visible)
end
end
end
Loading