Apply new rubocop rules on erb - Layout/ArgumentAlignment #11707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecslupu
added
the
type: internal
alecslupu
force-pushed
the
chore/erb-format
branch
from
8164661
to
07afb55
Compare
22 tasks
andreslucena
previously approved these changes
Oct 4, 2023
|
@andreslucena I had to merge with the latest develop to fix the conflicts.
|
As we've talked privately, lets leave this PR in stand by. If we merge this (and the different new rules) we will have lots of conflicts and currently we have 40 open PRs. We should lower this number until 10 or so, so the number of conlicts is lower too. |
Merged
alecslupu
force-pushed
the
chore/erb-format
branch
from
beb3175
to
7f9593d
Compare
andreslucena
approved these changes
Oct 14, 2023
andreslucena
changed the title
|
Merging as per @andreslucena 's approval. |
andreslucena
pushed a commit
that referenced
this pull request
Oct 16, 2023
entantoencuanto
added a commit
that referenced
this pull request
Oct 17, 2023
* develop: (30 commits) Add `process-content` to erb-lint's deprecated classes (#11762) Add possibility of overriding the tailwind.config.js (#11763) Ask old password when changing email or password (#11737) Add Projects (Budgets) to filtered search (#11740) Fix missing results on Geocoded when search without diacritics (#11761) Add robots.txt instructions (#11693) Add missing activerecord budget locales for search (#11766) Improve design of Admin's Sidebar pages (#11759) Show small static map on admin's meetings index with big screens (#11715) Remove "Manage" button when there's a Sidebar (#11717) Fix admin breadcrumb in Process (#11757) Apply new rubocop rules on erb - Layout/MultilineMethodCallIndentation (#11756) Remove xlarge-* references from admin forms (#11712) Apply new rubocop rules on erb - Argument identation (#11707) Update HERE API autocomplete (#11507) Admin redesign proposal issues (#11668) Redesign: responsive links on cards (#11538) Refactor CI pipelines (#11196) Update postcss and graphql to latest versions (#11733) Fix develop pipeline (#11750) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR Attempts to add more rubocop rules to erb linter. This was first highlighted by @andreslucena in #11696 (comment)
Testing