Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign: remove show page from Process in Admin #11682

Merged
merged 6 commits into from
Oct 2, 2023
Merged

Redesign: remove show page from Process in Admin #11682

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift click to select a range
1c62fb1
Remove show page from Process in Admin
andreslucena Sep 29, 2023
bfc5860
Merge branch 'develop' into remove/process-show
andreslucena Sep 29, 2023
d4ff069
Remove unecessary code
andreslucena Oct 2, 2023
8836ed9
Merge branch 'develop' into remove/process-show
andreslucena Oct 2, 2023
1ad5025
Undo removal of wrong initializer
andreslucena Oct 2, 2023
cdd79b2
Remove unecessary code (now it's the right one, hopefully!)
andreslucena Oct 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove unecessary code 
Suggested through code review
  • Loading branch information
@andreslucena
andreslucena committed Oct 2, 2023
commit d4ff0696aa31500ff3e6c4930b3dd80a71200de7
4 changes: 0 additions & 4 deletions decidim-admin/app/helpers/decidim/admin/menu_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,10 68,6 @@ def breadcrumb_root_admin_menu
)
end

def aside_menu(target_menu)
::Decidim::Admin::AsideMenuPresenter.new(target_menu, self)
end

def simple_menu(target_menu:, options: {})
options = { active_class: "is-active" }.merge(options)
::Decidim::Admin::SimpleMenuPresenter.new(target_menu, self, options)
Expand Down
20 changes: 0 additions & 20 deletions decidim-participatory_processes/lib/decidim/participatory_processes/admin_engine.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,26 148,6 @@ class AdminEngine < ::Rails::Engine
end
end

initializer "decidim_participatory_processes_admin.process_components_menu" do
Decidim.menu :admin_participatory_process_components_menu do |menu|
current_participatory_space.components.each do |component|
caption = translated_attribute(component.name)
if component.primary_stat.present?
caption = content_tag(:span, component.primary_stat, class: component.primary_stat.zero? ? "component-counter component-counter--off" : "component-counter")
end

menu.add_item [component.manifest_name, component.id].join("_"),
caption.html_safe,
manage_component_path(component),
active: is_active_link?(manage_component_path(component)) ||
is_active_link?(decidim_admin_participatory_processes.edit_component_path(current_participatory_space, component)) ||
is_active_link?(decidim_admin_participatory_processes.edit_component_permissions_path(current_participatory_space, component)) ||
participatory_space_active_link?(component),
if: component.manifest.admin_engine && user_role_config.component_is_accessible?(component.manifest_name)
end
end
end

initializer "decidim_participatory_processes_admin.process_components_right_menu" do
Decidim.menu :admin_participatory_process_components_right_menu do |menu|
menu.add_item :edit_participatory_process,
Expand Down