Redesign: remove show page from Process in Admin #11682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreslucena
added
module: admin
module: participatory processes
contract: redesign
alecslupu
requested changes
Sep 29, 2023
There was a problem hiding this comment.
There a few things that i would remove before merging this PR:
-
Remove
decidim_participatory_processes_admin.process_components_right_menuinitializer fromdecidim-participatory_processes/lib/decidim/participatory_processes/admin_engine.rb -
Remve
aside_menumethod fromdecidim-admin/app/helpers/decidim/admin/menu_helper.rb -
Fix conflict 😄
16 tasks
Suggested through code review
|
@andreslucena after the change performed, there are a lot of pipelines failing. We need to remove Not the best naming convention there. |
Suggested through code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
We have a show page from Processes but we're not happy with the current approach, as there are some missing elements from the Figma mockup.
On @decidim/product we've talked that until this page has at least some other features, currently is not usable. What we missed was the "Last activity" block from the mockup, and also having the links to publish/unpublish/configure/manage Components.
On the other hand, with the introduction of the sidebar the links that it has are redundant, so we need to iterate also in the sidebar menu and the relation with this page (i.e. having a collapsed Components section there?)
Finally, another problem with this particular page is that its only implemented in Processes, and it makes weird the navigation of the other spaces. The first time I got into the admin and started clicking things, I could not know what was happening with Assemblies, and it was that it wasn't consistent with Processes.
This PR removes this page. We will reintroduce it once we're happy with the new approach.
Testing
📷 Screenshots
Mockup of the Process show page:
Current (removed) page: