Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 'Fix HTML titles in admin panel (part 2)' to v0.27 #11336

Conversation

andreslucena
Copy link
Member

🎩 What? Why?

Backport #11116 to v0.27

♥️ Thank you!

* Fix admin titles part 2

* HTML titles added to the components of modules

* Apply suggestions from code review

Checked and committed!

Co-authored-by: Andrés Pereira de Lucena <[email protected]>

* Updated i18n-tasks

* Changes to merge

* Update on i18n locales

* Added changes to the i18n translations

* Update to translations on admin logs index

* Update decidim-admin/app/views/decidim/admin/logs/index.html.erb

Co-authored-by: Andrés Pereira de Lucena <[email protected]>

* Update decidim-accountability/app/views/decidim/accountability/admin/import_results/new.html.erb

Co-authored-by: Alexandru Emil Lupu <[email protected]>

* Update decidim-accountability/app/views/decidim/accountability/admin/projects_import/new.html.erb

Co-authored-by: Alexandru Emil Lupu <[email protected]>

* Update decidim-accountability/app/views/decidim/accountability/admin/results/edit.html.erb

Co-authored-by: Alexandru Emil Lupu <[email protected]>

* New changes made to html title parsing of H2

* Final clean up of i18n translations part 2

---------

Co-authored-by: Andrés Pereira de Lucena <[email protected]>
Co-authored-by: Alexandru Emil Lupu <[email protected]>
@andreslucena andreslucena added backport Pull Requests that are a backport for a fixed bug module: admin type: fix PRs that implement a fix for a bug labels Jul 24, 2023
Copy link
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alecslupu alecslupu added this to Pending review from Product in Maintainers via automation Jul 24, 2023
@alecslupu alecslupu merged commit 7178650 into release/0.27-stable Jul 25, 2023
36 checks passed
Maintainers automation moved this from Pending review from Product to Done Jul 25, 2023
@alecslupu alecslupu deleted the backport/0.27/fix-html-titles-in-admin-panel-11116 branch July 25, 2023 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Pull Requests that are a backport for a fixed bug module: admin type: fix PRs that implement a fix for a bug
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants