Fix for sending welcome emails for new participants #10991
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Reviewing old PRs, I found that the welcome email feature wasn't working with the introduction of digest emails (see #8486). @arusa explained it really well in #10470:
Then @ahukkanen explained how to approach this exception change in a comment, and as its a PR that's without much movement, it's an ongoing bug on the last release, and we already have the code, I went ahead and do it 😄
Thanks both of you for detecting and telling how to fix this! 👏🏽 👏🏽
📌 Related Issues
Testing
📷 Screenshots