-
-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the Elections' setup minimum hours before start setting to 1 hour #10900
Conversation
f7ba559
to
b9a1fbf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Genererating a new application will provide a default value of 3, due to generator template. Could you fix this, please?
config.setup_minimum_hours_before_start = Rails.application.secrets.dig(:elections, :setup_minimum_hours_before_start).presence || 3 |
I've missed that one, nice catch! Done at 340cce0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Fix error message mismatch in election * Fixing hour pluralization after #10900
* Fix error message mismatch in election * Fixing hour pluralization after #10900
* Fix error message mismatch in election * Fixing hour pluralization after #10900
* Fix error message mismatch in election * Fixing hour pluralization after #10900
* Fix error message mismatch in election * Fixing hour pluralization after #10900
* Fix error message mismatch in election * Fixing hour pluralization after #10900
* Fix error message mismatch in election * Fixing hour pluralization after #10900
* Fix error message mismatch in election * Fix error message mismatch in election * Fixing hour pluralization after #10900 * Apply review recommendations * Fix the failing spec
* Fix error message mismatch in election * Fix error message mismatch in election * Fixing hour pluralization after #10900 * Apply review recommendations * Fix the failing spec
🎩 What? Why?
When working with an Election, by default you need to set it up 3 hours before it starts. This means that every single time that you need to try one Election you need to do it 3 hours before.
This PR changes this to 1 hour, as it makes sense to development and also to production/staging instances. Mind that this is an Env Var that can be changed in the different installations, and in a real-world Election this actually should be done a couple days before.
Testing
📷 Screenshots