Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More public methods for matrix #70

Merged
merged 6 commits into from
May 10, 2023
Merged

More public methods for matrix #70

merged 6 commits into from
May 10, 2023

Conversation

Megidd
Copy link
Contributor

@Megidd Megidd commented May 8, 2023

To fix #69.

The Get and Set methods are inspired by:

// Get the n-th component of the vector.

@Megidd Megidd changed the title More public methods for 4x4 matrix More public methods for matrix May 9, 2023
@Megidd
Copy link
Contributor Author

Megidd commented May 9, 2023

Test

I have tested the get & set methods of M44. They work fine ✔️

I didn't test those of M33 and M22. The only possible bug might be a copy-paste-edit one.

@Megidd
Copy link
Contributor Author

Megidd commented May 10, 2023

Test

I tested the new API of sdf.NewM44 ✔️ But not the rest.

@deadsy deadsy merged commit 50221c3 into deadsy:master May 10, 2023
@deadsy
Copy link
Owner

deadsy commented May 10, 2023

Merged - I'll probably change the API to take a slice of values rather than a fixed sized array.

@Megidd Megidd deleted the m44 branch May 11, 2023 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initialize a 4x4 matrix i.e. sdf.M44
2 participants