Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add aiohttp_debugtoolbar to make debugging the web installer easier #863

Closed
wants to merge 1 commit into from
Closed

Add aiohttp_debugtoolbar to make debugging the web installer easier #863

wants to merge 1 commit into from

Conversation

cmaloney
Copy link
Contributor

Enabled whenever --web --verbose is run.

@orsenthil
Copy link
Contributor

Would --debug be a better flag as that's the purpose of this hook?

orsenthil
orsenthil reviewed Oct 13, 2016
View reviewed changes
dcos_installer/async_server.py
@@ -360,6 361,10 @@ def start(cli_options):
make_default_config_if_needed('genconf/config.yaml')
loop = asyncio.get_event_loop()
app = build_app(loop)

if options.verbose:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of verbose, should it be a debug?

(that's my only comment. everything else LGTM).

@cmaloney
Copy link
Contributor Author

cmaloney commented Oct 13, 2016 •
edited
Loading

--verbose is pre-existing and already defined as debug semantically (sets logging to debug level). Trying to be a minimal change here of making debugging the aiohttp app easier.

@orsenthil
Copy link
Contributor

Okay. reasoning sounds good to me.

Ship-it.

@cmaloney
Copy link
Contributor Author

Things which aren't passing all the tests shouldn't ever be given ship its...

@orsenthil
Copy link
Contributor

Okay. I will review it again once you have gotten it right.

@cmaloney
Copy link
Contributor Author

Closing for now, no time to work on it. Will re-work later. Will help when we rework the web apis

@cmaloney cmaloney closed this Nov 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orsenthil orsenthil orsenthil left review comments

Assignees
No one assigned
Labels
Work In Progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmaloney @orsenthil