-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Train 57 #581
Merged
Merged
Train 57 #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ZK URL for master and agent overlay module can now be learned from 'MESOS_ZK' on the master and 'MESOS_MASTER' on the agent. So specifying these URLs in the JSON should not be necessary.
Over time working on removing the "slave" terminology. See https://issues.apache.org/jira/browse/MESOS-1478 for some history
…andard CoreOS at least has /etc/lsb-release and /etc/oem-release which both have different info.
…p and related bits unless we're using it from the CLI
cli.py had very little code, cli_dispatcher doesn't in globals do any bad state mutation. Even if it had, we were importing it fully which would have picked that up anyways.
Does the same thing, simpler path. There was nothing else in the folder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#294, #557, #576, #577, #578, #579