Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Add batch_id to microbatch jinja context #11031

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[WIP] Add batch_id to microbatch jinja context #11031

wants to merge 2 commits into from
14 −2

Conversation

QMalcolm
Copy link
Contributor

Resolves #

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@QMalcolm QMalcolm added the Skip Changelog Skips GHA to check for changelog file label Nov 21, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.53%. Comparing base (a42303c) to head (3e23199).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #11031       /-   ##
==========================================
- Coverage   89.15%   86.53%   -2.62%     
==========================================
  Files         183      183              
  Lines       23764    23768        4     
==========================================
- Hits        21186    20568     -618     
- Misses       2578     3200      622
Flag Coverage Δ
integration 86.53% <100.00%> ( <0.01%) ⬆️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 86.53% <100.00%> (-2.62%) ⬇️
Integration Tests 86.53% <100.00%> ( <0.01%) ⬆️
---- 🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@QMalcolm