Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update QUICKSTART.md #186

Merged
merged 2 commits into from
Feb 19, 2024
Merged

Update QUICKSTART.md #186

merged 2 commits into from
Feb 19, 2024

Conversation

markp3rry
Copy link
Contributor

Made some edits based on experience of following this tutorial in v3.5.1 of Godot. I was able to complete the tutorial from start to finish, and end up with a working version of the sandbox with a deck containing the two custom cards that I could draw from.

Made some edits based on experience of following this tutorial in v3.5.1 of Godot. I was able to complete the tutorial from start to finish, and end up with a working version of the sandbox with a deck containing the two custom cards that I could draw from.
@db0
Copy link
Owner

db0 commented Feb 18, 2024

Question, does this still work on the latest 3.5.x? Why use 3.5.1?

@markp3rry
Copy link
Contributor Author

Question, does this still work on the latest 3.5.x? Why use 3.5.1?

Only reason is that it's the version I have on my laptop. I see that the latest LTS is 3.5.3 so if it's better to upgrade to that and test these changes again then happy to do that.

@db0
Copy link
Owner

db0 commented Feb 18, 2024

yes please, just run a quick test if you can on the latest

@markp3rry
Copy link
Contributor Author

yes please, just run a quick test if you can on the latest

I have downloaded 3.5.3 and opened the project, compiled and run the deck builder without any issues.

Small change to say updated for 3.5.3 rather than 3.5.1 as originally stated.
@markp3rry
Copy link
Contributor Author

I have updated the change to the quickstart.md to say 3.5.3 and not 3.5.1.

@db0 db0 merged commit 932414f into db0:main Feb 19, 2024
@markp3rry markp3rry deleted the patch-1 branch May 13, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants