Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to Estree import attributes #704

Closed
aralroca opened this issue Mar 20, 2024 · 3 comments
Closed

Add support to Estree import attributes #704

aralroca opened this issue Mar 20, 2024 · 3 comments
Labels
enhancement

Comments

@aralroca
Copy link

Import attributes is now already in runtimes as Bun for macros and is in stage 3 in Estree, I think it would be nice to support it in astring.

References:
@davidbonnet
Copy link
Owner

True, let's add that.

@aralroca
Copy link
Author

@davidbonnet I wanted to try to contribute but I am having problems running the tests:

Screenshot 2024-07-22 at 16 51 57

The only thing I have done is npm i && npm test, what I'm missing? As a suggestion, it would be nice to create a CONTRIBUTING.md 😊 file.

BTW; this meriyah/meriyah#280 is the PR of meriyah to support import attributes. It will probably be available in the next release.

@dividedmind dividedmind mentioned this issue Jul 31, 2024
Merged
@dividedmind dividedmind mentioned this issue Aug 8, 2024
Merged
@aralroca
Copy link
Author

This is fixed !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davidbonnet @aralroca