Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dmenu] - option to select all, invert selection and deselect all #666

Open
carnager opened this issue Sep 8, 2017 · 7 comments
Open

[dmenu] - option to select all, invert selection and deselect all #666

carnager opened this issue Sep 8, 2017 · 7 comments
Assignees

Comments

@carnager
Copy link
Collaborator

carnager commented Sep 8, 2017

rofi allows to select multiple lines, which then can be used in a loop.
It would be nice if the user could somehow select all visible lines (e.g. after filtering down the list)

To make this even more useful an option to invert the selection and deselect everything would be nice to to have.

@DaveDavenport
Copy link
Collaborator

Suggestions for default keybinding?

@DaveDavenport DaveDavenport self-assigned this Sep 11, 2017
@carnager
Copy link
Collaborator Author

oops, sorry haven't seen this.
To keep related bindings close to another, maybe Alt a (all), Alt s (switch/invert) and alt d (deselect) seem reasonable?

@ttygde
Copy link

ttygde commented Jan 4, 2019

surprised it is not implemented yet
i want to use rofi to select which files to download in torrent file with aria2
screenshot https://imgur.com/a/mRB9FnB
also would be fantastic to be able to select/deselect all filtered items
and preselect all items as i most probably want to download everything
by the way thanks for this great tool, i use it heavily for many things such as clipboard, passwords and even browser history

@DaveDavenport
Copy link
Collaborator

surprised it is not implemented yet

Why?

@ttygde
Copy link

ttygde commented Jan 4, 2019

i started writing the code assuming it is basic functionality given that there is multi select mode available
suppose it shouldnt be difficult to implement
sorry if my words sound too demanding but would be great to have this feature

@DaveDavenport
Copy link
Collaborator

DaveDavenport commented Jan 4, 2019

I was just curious about the statement.

imho: The multi-selection thing is already a weird-functionality. As it is very specific to dmenu mode and is functionality not supported/used anywhere else in rofi. It currently high-jacks a keybinding to do its function and has a hack to draw the selection icon.

Adding the above bindings is not trivial, as:

  • There is no support for 'mode-specific' keybindings.
  • The dmenu mode cannot see what items are and are not visible.
    This would require a new interface (and possibly remove a separation of functionality.)

Personally I am unsure how advanced the 'dmenu' mode should be? At what point is it better to have a separate tool (with a better interface for this) instead of something added to an application launcher.

@ttygde
Copy link

ttygde commented Jan 4, 2019

i see
agreed that multi-selection is weird but if we can already select multiple items it's logical to have a keybinding for that
anyway you know how it works, it is up to you to decide

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants