Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(storage): unify commit path of table mutation and append #11626

Merged
merged 21 commits into from
Jun 5, 2023
Merged

refactor(storage): unify commit path of table mutation and append #11626

merged 21 commits into from
Jun 5, 2023

Conversation

zhyass
Copy link
Member

@zhyass zhyass commented May 30, 2023 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

  1. Remove precommit, use CommitSink
  2. refactor commit sink
  3. refactor recluster mutator
  4. remove fuse sink. instead of append transform

Closes #10391

@vercel
Copy link

vercel bot commented May 30, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
databend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2023 2:26pm

@zhyass zhyass marked this pull request as draft May 30, 2023 10:40
@mergify mergify bot added the pr-refactor this PR changes the code base without new features or bugfix label May 30, 2023
@zhyass zhyass marked this pull request as ready for review June 5, 2023 03:35
@zhyass zhyass marked this pull request as draft June 5, 2023 03:40
@zhyass zhyass marked this pull request as ready for review June 5, 2023 08:30
@zhyass zhyass added the ci-benchmark Benchmark: run all test label Jun 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2023

local cloud cloud

ClickBench Report

@zhyass zhyass added ci-benchmark Benchmark: run all test and removed ci-benchmark Benchmark: run all test labels Jun 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2023

local cloud cloud

ClickBench Report

@dantengsky
Copy link
Member

the rest looks good to me. 👍

@zhyass zhyass merged commit ea5d1ad into datafuselabs:main Jun 5, 2023
@zhyass zhyass deleted the feature_purge branch June 5, 2023 16:18
andylokandy pushed a commit to andylokandy/databend that referenced this pull request Nov 27, 2023
@zhyass @andylokandy
refactor(storage): unify commit path of table mutation and append (da…
9c2d0c4 
…tafuselabs#11626)

* refactor commit

* Add snapshot generator

* set backoff

* refactor commint_insertion

* update

* update

* fix test error

* fix tests

* fix test

* remove precommit

* fix error

* remove unused codes

* remove unused codes

* fix review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhang2014 zhang2014 zhang2014 approved these changes

@dantengsky dantengsky dantengsky approved these changes

@BohuTANG BohuTANG Awaiting requested review from BohuTANG

Assignees
No one assigned
Labels
ci-benchmark Benchmark: run all test pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor: unify commit path of table mutations
3 participants
@zhyass @dantengsky @zhang2014