Added Measurement Faker #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #194 /- ##
============================================
- Coverage 94.81% 94.70% -0.12%
- Complexity 1787 1794 7
============================================
Files 181 182 1
Lines 3781 3793 12
Branches 377 377
============================================
Hits 3585 3592 7
- Misses 102 104 2
- Partials 94 97 3
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
@bodiam, |
|
@Tahanima yeah, seems like we still have a flaky tests here somewhere. Your PR looks good though, so lets just merge it, the us phone number we'll fix later! Thanks again! |
You're welcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.