small fix to avoid raising a TypeError warning when snapping a picture #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge pull request dashesy#4 from bicv/master
laurentperrinet
added a commit
to bicv/pyavfcam
that referenced
this pull request
Dec 15, 2018
Merge pull request dashesy#5 from bicv/master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As demonstrated in the notebook, the
TypeErroris not raised anymore.This was resolved by adding a directive on the top of the
pyxfile https://github.com/dashesy/pyavfcam/compare/master...bicv:master?expand=1#diff-ed80a41a162d9773a0ccfbb5c2901667I also added small changes which I hope do not break any other things :-) a timing of the time it takes to take images (I achieve ~19 fps)
cheers