Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test specific rule. #138

Merged
merged 2 commits into from
Aug 31, 2023
Merged

Add a test specific rule. #138

merged 2 commits into from
Aug 31, 2023

Conversation

polina-c
Copy link
Contributor

No description provided.

Copy link

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

doc/TROUBLESHOOT.md Outdated Show resolved Hide resolved
Co-authored-by: chunhtai <47866232 [email protected]>
A test specific rule:
1. If your test creates a disposable object, it should dispose it in `tearDown`, so that test failure does not result in a leak:

```

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```
```dart

@auto-submit auto-submit bot merged commit 0298e20 into main Aug 31, 2023
2 checks passed
@auto-submit auto-submit bot deleted the polina-c-patch-1 branch August 31, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants