Reorganizing name files #426
Conversation
…wayFirstNamesBoys.json
…rwayFirstNamesGirls.json
|
Here's a simpler view of the folder changes: https://github.com/tukkek/corpora/tree/names-folder/data/humans/names |
|
Corpora doesn't make any compatibility promises, so I think this is okay? Let's ask @dariusk :) |
A few more thoughts on this matter:
This is probably overkill argumentation just to get this issue merged but I'm hoping it may inform the project as a whole (as a data-focused project in comparison to a programming library API or similar). I do appreciate the discussion though, as it may ultimately affect end-users! Cheers to all. |
Since it's been a week with no opinions against (and considering previous discussion), do you think it'd be alright to merge? |
After #425, there are 9 files in
humans/relating to names, which is a substantial chunk of the folder. I've taken the liberty of reorganizing them in this PR rather than creating an issue first to discuss the changes, with anames/sub-folder.Pros:
data/games/rpg/anddata/words/literature/).humans/).Cons:
git-submodule, for example).As per 3, I've taken the liberty to rename the files for a more elegant and cohesive naming scheme. for example:
firstNanes.jsonandlastNames.jsontousa.jsonandusaSurnames.jsonnorwayFirstNamesBoys.jsontonorwayMale.jsonI hope the benefits out-weight the compatibility issue, especially as it's safe to expect more name-related files to be added again in the future but I understand this might be a concern for some projects.
Here's a simpler view of the folder changes: https://github.com/tukkek/corpora/tree/names-folder/data/humans/names