Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Presidential quotes #41

Merged
merged 2 commits into from
Nov 11, 2014
Merged

Conversation

amarriner
Copy link
Contributor

A small list of quotes from US presidents (source). Also in the JSON is an ID that can be used to match the president to govtrack.us API calls if desired. I also have a JSON file of US presidents, but since that was just pulled as-is from govtrack.us I didn't think it made sense to put it in this repo?

@dariusk
Copy link
Owner

dariusk commented Nov 11, 2014

Ask not what corpora can do for you, but what you can do for corpora.

dariusk added a commit that referenced this pull request Nov 11, 2014
@dariusk dariusk merged commit 147d011 into dariusk:master Nov 11, 2014
@amarriner amarriner deleted the presidential_quotes branch November 11, 2014 14:53
@MichaelPaulukonis
Copy link
Contributor

I also have a JSON file of US presidents, but since that was just pulled as-is from govtrack.us I didn't think it made sense to put it in this repo?

By all means, add it in? Since not everybody knows where to go for it (and the list changes so often)!

since it is JSON, we can't exactly leave in a comment to the source, but you could add a readme.md file noting same.

@dariusk
Copy link
Owner

dariusk commented Nov 11, 2014

There's a "description" field that many corpora files use at the root level of the JSON object which is meant for sourcing and other notes.

@amarriner
Copy link
Contributor Author

Created a pull request for it (with an added description).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants