Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a list of pre-modern combat weapons #354

Merged
merged 3 commits into from
Oct 31, 2021
Merged

Conversation

jd7h
Copy link
Contributor

@jd7h jd7h commented Oct 22, 2019

JSON has been linted according to contribution instruction. :)

This might come in handy for projects with a medieval or fantasy setting.
I tried to include only weapons that are fairly well-known.
@hugovk
Copy link
Collaborator

hugovk commented Oct 30, 2021

Thank you for the PR! Please can you make them all lowercase? That way they fit into the middle of sentences when using templates like Tracery.

@jd7h
Copy link
Contributor Author

jd7h commented Oct 31, 2021

Fixed :)

@hugovk hugovk merged commit 05e1b66 into dariusk:master Oct 31, 2021
@hugovk
Copy link
Collaborator

hugovk commented Oct 31, 2021

Thanks!

@jd7h jd7h deleted the patch-1 branch November 2, 2021 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants