Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make file size more compact #203

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

caub
Copy link

@caub caub commented Mar 20, 2021

Guys, could we do something like that? Else all the decimals and stuff makes the visualization quite cluttered, less readable

@nikolay-borzov @danvk

Thanks for that lib also

@caub caub force-pushed the compact-file-sizes branch 2 times, most recently from 7664d98 to 5e22d48 Compare March 20, 2021 13:24
@nikolay-borzov
Copy link
Collaborator

Thank you for your contribution. I'm considering switching source-map-explorer visualization to foam-tree #185. Take a look. We might change what is displayed inside visualization blocks

@caub
Copy link
Author

caub commented Mar 20, 2021

@nikolay-borzov Oh, well I've also used https://www.npmjs.com/package/webpack-bundle-analyzer (which uses foam-tree), and I kinda like the simplicity of source-map-explorer currently, it's just my take on it, but I like more the current way, more minimal

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.397% when pulling c045a12 on caub:compact-file-sizes into 0de5602 on danvk:master.

@danvk
Copy link
Owner

danvk commented Mar 22, 2021

@caub thanks for the PR. Can you include a before/after screenshot where you see this improving legibility?

@caub
Copy link
Author

caub commented Mar 22, 2021

2021-03-20-142815_563x501_scrot
2021-03-20-142724_561x502_scrot

The difference is small, but overall it's lighter (shorter unitssymbol, and 3 significant digits: 119.08 KB119K)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants