Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Cloudflare Turnstile as alternative to Google reCAPTCHA #763

Merged
merged 1 commit into from
May 21, 2024

Conversation

KuJoe
Copy link
Sponsor Contributor

@KuJoe KuJoe commented May 21, 2024

Added the option to select Cloudflare's Turnstile instead of Google's reCAPTCHA for the login page due to it's less intrusive usage and better accessibility options.

@danpros this changes some of the variable names in the config.ini file, how would these variable names be updated for users who do the automatic update?

image
image

Added the option to select Cloudflare's Turnstile instead of Google's reCAPTCHA for the login page due to it's less intrusive usage and better accessibility options.
@danpros danpros merged commit 9d57e78 into danpros:master May 21, 2024
@danpros
Copy link
Owner

danpros commented May 21, 2024

Thank you!

how would these variable names be updated for users who do the automatic update?

They need to re configure it again, but it's fine. You need to remove the old config from configList.json so the old config will automatically show up in config/custom, they can copy paste it from there.

@danpros
Copy link
Owner

danpros commented May 21, 2024

It would be great if we have new site wide config to disable MFA feature so we can hide those MFA input from login page.

@KuJoe
Copy link
Sponsor Contributor Author

KuJoe commented May 21, 2024

It would be great if we have new site wide config to disable MFA feature so we can hide those MFA input from login page.

Good idea, PR added.

In the future I will go through and find a better solution for handling MFA so it only prompts users with it enabled and only after they've authenticated with username and password, but I didn't want to rewrite the whole login process so this current implementation was the easiest solution for now.

@danpros
Copy link
Owner

danpros commented May 21, 2024

Please, go ahead. You can go crazy with htmly but please make it as simple as possible. Performance, security, and simplicity is the key.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants