Tooltip to inform of reason for disabled action #3239
40
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danny-avila
requested changes
Jun 30, 2024
| <div className="relative mt-2 h-8 rounded-lg bg-transparent font-medium"> | ||
| <TooltipProvider delayDuration={0}> | ||
| {' '} | ||
| {/* TODO: refactor to use https://atomiks.github.io/tippyjs/ */} |
| </button> | ||
| {disabledActionTip && ( | ||
| <div className="absolute bottom-10 left-0 z-10 rounded bg-white p-2 shadow dark:bg-gray-800"> | ||
| {/* TODO: incorporate localize */} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
I added the following TODOs:
{/* TODO: incorporate localize */}I did not incorporate the translations for this tooltip message{/* TODO: refactor to use https://atomiks.github.io/tippyjs/ */}Using this custom tooltip UI is convoluted tippyjs could significantly simplify this.Summary
when creating an action for an assistant the button is sometimes disabled if the assistant has not yet been created therefore without an explanation of why it's disabled this PR informs the user of why the button is disabled.
Change Type
Please delete any irrelevant options.
Testing
you click on assistance and then you go to assistant builder where you will see that for an assistant that is already created the action button is activated but if you try and create a new action the action button defaults to disabled that is when the tooltip shows why it is disabled.
Test Configuration:
Checklist
Please delete any irrelevant options.