#478 change list decoration placement logic #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syjer
force-pushed
the
478-li-style-decoration-positioning
branch
from
93b002c
to
6642768
Compare
syjer
force-pushed
the
478-li-style-decoration-positioning
branch
from
4c07c6d
to
5600297
Compare
|
Hi @danfickle , I've marked this PR as ready. I've added a new test which check with various fonts and sizes the RTL case. Like all the browsers, there will be cases where the marker will not be able to be put inside the default padding, so it will be cut (partially or totally). To be noted, as written in #478, we need to add the support for |
|
Looks good. Thank you. I'm working on an exciting feature (pr soon) but after that I'll take a look at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implement what has been done in the issue #478 .
I'll add another test (especially on the RTL side of the equation) before marking the PR as done :).