Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better flowing column support #380

Merged
merged 6 commits into from
Aug 19, 2019
Merged

Better flowing column support #380

merged 6 commits into from
Aug 19, 2019

Conversation

danfickle
Copy link
Owner

This PR implements:

  • Nested content such as p, ul, etc in flowing columns.
  • Floated boxes in flowing columns (with limitations).
  • Explicit column breaks.

Limitations:

  • Floated boxes that go over multiple columns are broken at arbitrary points so are best used explicitly at the start of a column where they will not be broken.
  • Column break boxes must be empty. For example: <div style="break-before: column;"></div>.
  • Container boxes are not resized or duplicated when broken over multiple columns, so should not have a background, overflow: hidden or border (except top).
  • Balanced columns are still not implemented.

@danfickle danfickle merged commit 661252f into open-dev-v1 Aug 19, 2019
@danfickle danfickle deleted the better_columns branch August 19, 2019 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant