rewrote enqueueBuffer without allocations #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new version of `enqueueBuffer` is now type stable and no longer performs any allocations. Benefits: * better thread safety (Julia does not allow allocations in C callbacks) * better real-time performance: less risk of garbage collection during playback. Other improvements: * fixes dancasimiro#69 such that enqueueBuffer no longer duplicates last sample of each buf in next buf * increases buffer size from 4 kiB to 16 kiB, to reduce risk of dropouts (dancasimiro#69) * modernized handling of references: callback function now receives `Ref{AudioQueueData{T,n}}` instead of `Ptr{AudioQueueData}`, so fewer unsafe_load/store! calls needed * replaced UnionAll type `Array` with concrete type `Array{T,N}` in `userData` * replaced 1-element Array hacks with Ref{}() * `AudioQueueEnqueueBuffer` is now a simple wrapper, i.e. could now also be used by a future wavrecord() extension to queue empty buffers for recording audio * new wavplay parameter assertion limits ndims of input array to 1 or 2 at compile time, thus eliminating a previous run-time check in enqueueBuffer
|
Thanks for another great contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new version of
enqueueBufferis now type stable and no longer performs any allocations.Benefits:
Other improvements:
Ref{AudioQueueData{T,n}}instead ofPtr{AudioQueueData}, so fewer unsafe_load/store! calls neededArraywith concrete typeArray{T,N}inuserDataAudioQueueEnqueueBufferis now a simple wrapper, i.e. could now also be used by a future wavrecord() extension to queue empty buffers for recording audio