-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test harness doesn"t run in parallel #9
Comments
Some of these futures seem to be referencing the salsa |
Hmm. I thought that each test created its own database? Not sure. |
I believe that they do, but IIRC some of the Kernel interpretation is async and uses the non-Send db. I"ll check again. |
Ah, I see. We should use a "non-workstealing" setup of tokio, or switch to glommio perhaps. We could also make things Send but I"m not sure that"s worth the bother. |
That said, I imagine everything is Send... |
I spent some time looking at this and got stuck once I started running tests in parallel and in arbitrary order. The shared LSP appears to deadlock within salsa while interning I"m stumped for now. Here"s my branch: https://github.com/brson/dada/tree/parallel-tests |
We just landed a PR fixing a potential deadlock with interning in salsa, so that may be related. |
I rebased my parallel testing branch and it still deadlocks. Haven"t investigated further. |
It should. Shouldn"t be that hard, maybe just call
tokio::spawn
around this calldada/components/dada-lang/src/test_harness.rs
Lines 40 to 42 in cff3102
and add some joins later on?
The text was updated successfully, but these errors were encountered: