Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minifying the share url doesn"t work in playground #88

Open
nikomatsakis opened this issue Jan 22, 2022 · 0 comments
Open

minifying the share url doesn"t work in playground #88

nikomatsakis opened this issue Jan 22, 2022 · 0 comments
Labels
help wanted Extra attention is needed playground Dada playground tasks (often involve JS/HTML/CSS)

Comments

@nikomatsakis
Copy link
Member

The share button has some code to call out to is.gd to minify the URL, but it fails for access control reasons. I don"t know if there"s a way to solve that problem that works purely client-side -- if not, we should just remove that minification logic. I left it there for now since it is harmless enough.
@nikomatsakis nikomatsakis added help wanted Extra attention is needed playground Dada playground tasks (often involve JS/HTML/CSS) labels Jan 22, 2022
@nikomatsakis nikomatsakis changed the title minifying the url doesn"t work minifying the share url doesn"t work in playground Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed playground Dada playground tasks (often involve JS/HTML/CSS)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nikomatsakis