Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove network permission for F-Droid build #1428

Closed
tvnmguy opened this issue Oct 5, 2024 · 1 comment
Closed

Remove network permission for F-Droid build #1428

tvnmguy opened this issue Oct 5, 2024 · 1 comment
Labels
enhancement New feature, request, improvement or optimization FOSS

Comments

@tvnmguy
Copy link

tvnmguy commented Oct 5, 2024

According to your privacy policy;

Network permission are used mainly for checking new update and message of the day (MOTD) feature.

I believe MOTD is a fancy feature and that's not need necessary for this kinda app.

If I installed SDmaide SE from F-Droid and updating via F-Droid, so in that scenario F-Droid version no longer need internet permission.

I'm not comfortable with an app that has full network access which handle all system files.

In my view, all version of this app no longer need network permission because:

If someone installed via direct github release who can track and update this app via https://github.com/ImranR98/Obtainium

@tvnmguy tvnmguy added enhancement New feature, request, improvement or optimization triage This ticket needs to be sorted and labeled. labels Oct 5, 2024
@d4rken d4rken added FOSS and removed triage This ticket needs to be sorted and labeled. labels Oct 6, 2024
@d4rken
Copy link
Member

d4rken commented Oct 6, 2024

I'd be open to making the internet permission "optional" and granted at run-time (if a feature is used that requires it), but that is not supported by Android (as of now).

If I installed SDmaide SE from F-Droid and updating via F-Droid, so in that scenario F-Droid version no longer need internet permission.

While you are right that in some cases like installing from F-Droid, the update check is not needed, but there are also users who grab releases directly from GitHub without any 3rd party app inbetween.

I'm not comfortable with an app that has full network access which handle all system files.

SD Maid is fully open-source, feel free to check the source-code. If you don't trust the me, maybe you shouldn't use the app, there are ways to exfiltrate data even without internet permission. 🤷

Network permission are used mainly for checking new update and message of the day (MOTD) feature.

I believe MOTD is a fancy feature and that's not need necessary for this kinda app.

Both the update check and MOTD are features I want to have in the app, so the internet permission has to stay (for now) 🙁. Maybe a future Android version allows making it optional, then we could revisit this topic.

@d4rken d4rken closed this as not planned Won't fix, can't repro, duplicate, stale Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, request, improvement or optimization FOSS
Projects
None yet
Development

No branches or pull requests

2 participants