ViTBlock implementation match schema #2283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the schema presented at the top of the section is in agreement with the schema presented in the original paper (https://arxiv.org/abs/2010.11929), I therefore take this schema as the first reference to match the implementation with it. More specifically, I modify the implementation of the forward function of the ViTBlock object that I consider not to match the schema.
|
Job d2l-en/PR-2283/1 is complete. |
|
Job d2l-en/PR-2283/2 is complete. |
astonzhang
reviewed
Aug 30, 2022
chapter_attention-mechanisms-and-transformers/vision-transformer.md
Outdated
Show resolved
Hide resolved
chapter_attention-mechanisms-and-transformers/vision-transformer.md
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the schema presented at the top of the section is in agreement with the schema presented in the original paper (https://arxiv.org/abs/2010.11929), I therefore take this schema as the first reference to match the implementation with it. More specifically, I modify the implementation of the forward function of the ViTBlock object that I consider not to match the schema.
By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice.