Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configurable n-window #864

Closed
oliver-sanders opened this issue Dec 7, 2021 · 9 comments · Fixed by #1755
Closed

configurable n-window #864

oliver-sanders opened this issue Dec 7, 2021 · 9 comments · Fixed by #1755
Assignees
Milestone

Comments

@oliver-sanders
Copy link
Member

oliver-sanders commented Dec 7, 2021

Ideally the user would be able to set the n-window for each view independently.

A good use case would be an operator working on a complex workflow. They might want the tree view in n=1 and the graph view in n=0.

One day we would be able to construct an n-window around an arbitrary selection of start tasks which would enhance this further.

E.G. The operator could have the tree view open to n=1 and the graph view to an n=2 based around the tasks they are selecting in the tree view.

This would be useful in understanding the impacts of task failures, delays, bottlenecks, etc.

This is a complex thing to do and would require server-side assistance. I think the data store currently supports the concept of an arbitrary n-window selection.

Related:

Pull requests welcome!

@hjoliver
Copy link
Member

hjoliver commented Dec 7, 2021

One day we would be able to construct an n-window around an arbitrary selection of start tasks which would enhance this further.

Yeah that's definitely on the wanted list.

@oliver-sanders
Copy link
Member Author

One day we would be able to construct an n-window around an arbitrary selection of start tasks which would enhance this further.

Note: This will require data provision on the backend (the same provision required for n>1 windows).

@oliver-sanders
Copy link
Member Author

The n-window also has a role in managing "offline" (historical) task/job information since n=cycle e.g. n=20200101 means "all tasks from the cycle 20200101 irrespective of their edge distance from active tasks".

See also: cylc/cylc-uiserver#378

@oliver-sanders
Copy link
Member Author

oliver-sanders commented Jul 3, 2023

Blocked by cylc/cylc-flow#5609 and limitations of the currently algorithm which cause it to miss cousin nodes.

@ColemanTom
Copy link

Just looking through and saw this one. The Issue you had blocking this is closed, is this still blocked?

@hjoliver
Copy link
Member

Thanks for the heads-up, this should be unblocked now, but @oliver-sanders can confirm.

@oliver-sanders
Copy link
Member Author

Yes this is no longer blocked. It should be relatively easy to get working, I got a prototype working in a few lines.

@steoxley
Copy link

This would be really useful in a rose-stem context which doesn't cycle and that people want to repeatedly rerun certain tasks that may otherwise would have fallen out of scope.

@oliver-sanders
Copy link
Member Author

This will be very useful for most contexts, unfortunately, we haven't had the time to work on it so far.

@oliver-sanders oliver-sanders self-assigned this Apr 16, 2024
@oliver-sanders oliver-sanders modified the milestones: Pending, 2.5.0 Apr 16, 2024
oliver-sanders added a commit to oliver-sanders/cylc-ui that referenced this issue Apr 16, 2024
* Closes cylc#864
* Add a selector for switching the n-window extent between 0 & 3
  inclusive.
* The n-window value appears to be preserved when navigating back to the
  workflow.
oliver-sanders added a commit to oliver-sanders/cylc-ui that referenced this issue Apr 16, 2024
* Closes cylc#864
* Add a selector for switching the n-window extent between 0 & 3
  inclusive.
* The n-window value appears to be preserved when navigating back to the
  workflow.
oliver-sanders added a commit to oliver-sanders/cylc-ui that referenced this issue Apr 19, 2024
* Closes cylc#864
* Add a selector for switching the n-window extent between 0 & 3
  inclusive.
* The n-window value appears to be preserved when navigating back to the
  workflow.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants