Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stall status bug #6200

Merged
merged 4 commits into from
Jul 9, 2024
Merged

Fix stall status bug #6200

merged 4 commits into from
Jul 9, 2024

Conversation

MetRonnie
Copy link
Member

@MetRonnie MetRonnie commented Jul 4, 2024

Closes #6199. A stalled paused workflow would incorrectly have a status of running instead of paused.

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • No dependency changes
  • Tests are included
  • CHANGES.md entry included if this is a change that can affect users
  • No docs entry needed.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@MetRonnie MetRonnie added the bug Something is wrong :( label Jul 4, 2024
@MetRonnie MetRonnie added this to the 8.3.2 milestone Jul 4, 2024
@MetRonnie MetRonnie self-assigned this Jul 4, 2024
Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a couple of minor suggestions.

cylc/flow/workflow_status.py Outdated Show resolved Hide resolved
cylc/flow/workflow_status.py Outdated Show resolved Hide resolved
@@ -209,7 209,7 @@ def get_time_string_from_unix_time(unix_time, display_sub_seconds=False,
to use as the time zone designator.

"""
date_time = datetime.utcfromtimestamp(unix_time)
date_time = datetime.fromtimestamp(unix_time, timezone.utc)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For future reference, please raise changes like this against master, not a bugfix release.

@hjoliver hjoliver merged commit bb64e9f into cylc:8.3.x Jul 9, 2024
22 of 25 checks passed
@MetRonnie MetRonnie deleted the stall-status branch July 9, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong :(
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stalled paused workflows incorrectly have running status
3 participants