play: print the logo to the user's terminal only #6170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxtim
reviewed
Jun 26, 2024
| if ( | ||
| cylc.flow.flags.verbosity > -1 | ||
| and (options.no_detach or options.format == 'plain') | ||
| # don't print the startup message on reinvocation (note |
There was a problem hiding this comment.
Are you happy to skip the Logo if I set --localhost manually? I'm fine with it.
There was a problem hiding this comment.
Yes, this is a caveat of the hacky approach, however, it avoids the need for another CLI argument and there is very little use case for specifying localhost.
wxtim
approved these changes
Jun 26, 2024
There was a problem hiding this comment.
It's remarkably similar to what I tried, but I didn't hit on using --host=localhost as the test for having been re-invoked.
Have tried it manually.
IMO - tick the testing box with a note explaining that you can't test this automatically. Either tick the changes log and add a change log, or tick it and explain why not.
wxtim
reviewed
Jun 27, 2024
MetRonnie
requested review from
MetRonnie
and removed request for
markgrahamdawson
MetRonnie
requested changes
Jun 27, 2024
|
(rebased) |
MetRonnie
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6166.
We don't have reinvokation tests in CI ATM, so manual testing please. The logo should appear once and only once, in the user's terminal and no where else.
@wxtim, please review and assign (2) when happy.
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).CHANGES.mdentry included if this is a change that can affect users?.?.xbranch.