data store: add absolute graph edges #6103
Conversation
oliver-sanders
changed the title
|
I might have shifted some code about also.. I guess this is separate to the issue of spawning off |
|
Actually yeah, so I've only included it in the same cycle (like you said)... it makes sense WRT limiting the edges to |
oliver-sanders
force-pushed
the
data-store.add-aboluste-graph-edges
branch
from
2957e50
to
ec7e16d
Compare
oliver-sanders
force-pushed
the
data-store.add-aboluste-graph-edges
branch
from
ec7e16d
to
5e6e741
Compare
|
Added a test and changelog, rebased onto 8.3.x. @wxtim Assigned for review 2, well worth a good play with the graph view (static |
Co-authored-by: Tim Pillinger <26465611 [email protected]>
|
What about this equivalent bit in cylc-flow/cylc/flow/taskdef.py Lines 49 to 51 in 4d6430a |
(haven't forgotten about this, still catching up with my inbox). A good point that I either don't have an answer to or simply can't remember. I don't think I've seen any consequences of this (abs deps seem to work fine, perhaps this is the graph walking algorithm doing its job?). Opened an issue. |
Closes #5845
Include absolute graph edges into the data store.
At present, absolute graph parents apply only when the parent is in the same cycle as the child.
E.G. Taking this example:
The
build => rungraph edge would only exist in the R1 cycle (the one in which the build task was scheduled to run) rather than all subsequent cycles to which it applied.The cause of the bug was a bit of code that was purposefully filtering out absolute graph edges which point to tasks in cycles other than the one that the child task is in. The code contained this comment which suggests doing this resolved some other issue:
Taking this code out fixes #5845, but I'm worried that this code served a purpose and that by deleting it I'm solving one problem by introducing another.
The comment first appeared here:
416240f#diff-e67a65e5cc6c5da815c97f19bf1afc269d56a7f032351aa72364a414ae726048R84
I can't track down why it was added by scanning through #3811. Long shot, @dwsutherland you don't have any memory of this (3 years ago!)?
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).CHANGES.mdentry included if this is a change that can affect users?.?.xbranch.