cylc vip/vr: do not pass rose options to cylc play
#6102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just codecov upload failing |
oliver-sanders
approved these changes
May 15, 2024
wxtim
approved these changes
May 15, 2024
|
D'OH! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #6068
cylc playno longer accepts cylc-rose options (-O,-S,-D) as of #6068. However, it was not noticed that we were still passing the options tocylc playas part ofcylc vip/vr. This only seemed to cause a problem with remote reinvocation, where the workflow would not play and gave an error saying e.g. "no such option-O".Check List
CONTRIBUTING.mdand added my name as a Code Contributor.CHANGES.mdentry included if this is a change that can affect users?.?.xbranch.