Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that sys argv cleaner cleans up --workflow-name=foo #5909

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Ensure that sys argv cleaner cleans up --workflow-name=foo #5909

merged 2 commits into from
Jan 9, 2024

Conversation

wxtim
Copy link
Member

@wxtim wxtim commented Jan 8, 2024 •
edited
Loading

as well as --workflow-name foo

Closes #5905

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • CHANGES.md entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@wxtim wxtim added this to the cylc-8.2.4 milestone Jan 8, 2024
@wxtim wxtim self-assigned this Jan 8, 2024
@wxtim wxtim added the bug Something is wrong :( label Jan 8, 2024
@oliver-sanders
Copy link
Member

Note: To test, configure [run hosts]available so that your workflows detach and run on a different host.

@markgrahamdawson markgrahamdawson merged commit 9948532 into cylc:8.2.x Jan 9, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliver-sanders oliver-sanders oliver-sanders approved these changes

@markgrahamdawson markgrahamdawson markgrahamdawson approved these changes

Assignees

@wxtim wxtim

Labels
bug Something is wrong :(
Projects
None yet
Milestone
cylc-8.2.4
Development

Successfully merging this pull request may close these issues.
3 participants
@wxtim @oliver-sanders @markgrahamdawson