Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pbs: trim trailing text from job ids #5616

Merged
merged 3 commits into from
Jul 17, 2023
Merged

pbs: trim trailing text from job ids #5616

merged 3 commits into from
Jul 17, 2023

Conversation

oliver-sanders
Copy link
Member

@oliver-sanders oliver-sanders commented Jul 4, 2023 •
edited
Loading

Candidate fix for #4051.

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • CHANGES.md entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@oliver-sanders oliver-sanders self-assigned this Jul 4, 2023
dpmatthews
dpmatthews approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@dpmatthews dpmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've done some basic tests and this seems fine

@oliver-sanders oliver-sanders marked this pull request as ready for review July 11, 2023 11:58
@oliver-sanders oliver-sanders added this to the cylc-8.2.0 milestone Jul 11, 2023
@oliver-sanders oliver-sanders added the bug Something is wrong :( label Jul 11, 2023
@oliver-sanders oliver-sanders requested review from hjoliver and wxtim and removed request for hjoliver July 11, 2023 12:00
@wxtim wxtim merged commit 33a30f1 into cylc:master Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxtim wxtim wxtim approved these changes

@dpmatthews dpmatthews dpmatthews approved these changes

Assignees

@oliver-sanders oliver-sanders

Labels
bug Something is wrong :(
Projects
None yet
Milestone
cylc-8.2.0
Development

Successfully merging this pull request may close these issues.

PBS: problem with truncated job identifier
3 participants
@oliver-sanders @dpmatthews @wxtim