cd to workflow dir during file parsing. #5589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 19, 2023
oliver-sanders
approved these changes
Jun 23, 2023
wxtim
reviewed
Jul 4, 2023
| @@ -401,6 401,12 @@ def read_and_proc( | |||
| fpath = _get_fpath_for_source(fpath, opts) | |||
| fdir = os.path.dirname(fpath) | |||
|
|
|||
| odir = os.getcwd() | |||
There was a problem hiding this comment.
Might be safer
try:
os.chdir(fdir)
finally:
os.chdir(odir)or even:
@contextmanager
def work_in(path):
before = os.getcwd()
try:
os.chdir(path)
finally:
os.chdir(before)
with work_in(fdir):
# ... stuff ...Kind of surprised that the latter isn't part of Pathlib.
There was a problem hiding this comment.
It doesn't actually matter if we don't os.chdir back afterwards, this only applies to the Python session itself not the parent shell.
There was a problem hiding this comment.
Note my change does os.chdir back afterwards. I agree it should not matter, but to explicitly avoid any side-effects of the dir change that I might not be aware of.
wxtim
reviewed
Jul 4, 2023
wxtim
reviewed
Jul 4, 2023
hjoliver
force-pushed
the
workflow-parsing-cwd
branch
from
4b8841b
to
54ee8fa
Compare
|
@wxtim - I tweaked the new test as you suggested. A final commit just cleans up the file to pass flake8. |
wxtim
approved these changes
Jul 10, 2023
|
I'll hit merge as soon as the tests finish./ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the template processor to access workflow files - in the source dir for a source workflow, or the run dir for installed workflows.
This is the most straightforward way to cater to this kind of use case
(I can't think of any downside...)
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).CHANGES.mdentry included if this is a change that can affect users?.?.xbranch.