Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix eval_host() localhost bug & plug testing gap #5506

Merged
merged 2 commits into from
May 2, 2023
Merged

Fix eval_host() localhost bug & plug testing gap #5506

merged 2 commits into from
May 2, 2023

Conversation

MetRonnie
Copy link
Member

@MetRonnie MetRonnie commented May 2, 2023 •
edited
Loading

Fixes bug where flow.cylc[runtime][X][remote]host = $(subshell cmd) would always result in localhost.

Follow up to #5343
Closes #5462

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • No dependency changes
  • Tests are included
  • CHANGES.md entry included if this is a change that can affect users
  • No docs change needed
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@MetRonnie MetRonnie added the bug Something is wrong :( label May 2, 2023
@MetRonnie MetRonnie added this to the cylc-8.1.4 milestone May 2, 2023
@MetRonnie MetRonnie self-assigned this May 2, 2023
@MetRonnie MetRonnie linked an issue May 2, 2023 that may be closed by this pull request
unit test: platform subshell evaluation #5462
Closed
@hjoliver hjoliver merged commit 1e38816 into cylc:8.1.x May 2, 2023
@MetRonnie MetRonnie deleted the eval-host branch May 3, 2023 09:17
@oliver-sanders oliver-sanders mentioned this pull request May 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliver-sanders oliver-sanders oliver-sanders approved these changes

@hjoliver hjoliver hjoliver approved these changes

@wxtim wxtim Awaiting requested review from wxtim

Assignees

@MetRonnie MetRonnie

Labels
bug Something is wrong :(
Projects
None yet
Milestone
cylc-8.1.4
Development

Successfully merging this pull request may close these issues.

unit test: platform subshell evaluation
3 participants
@MetRonnie @hjoliver @oliver-sanders