Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cat-log: support workflow files #5453

Merged
merged 2 commits into from
Apr 21, 2023
Merged

cat-log: support workflow files #5453

merged 2 commits into from
Apr 21, 2023

Conversation

oliver-sanders
Copy link
Member

@oliver-sanders oliver-sanders commented Apr 6, 2023 •
edited
Loading

Built atop: #5414

  • Add support for viewing other workflow log files e.g. the install/ and config/ logs.
  • Provide single letter abbreviations for the most recent workflow log file of each type.
  • Allow specifying the job submit number in the ID.
  • Fix a minor bug which allowed users to request cycle point log files.

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • CHANGES.md entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@oliver-sanders oliver-sanders added this to the cylc-8.2.0 milestone Apr 6, 2023
@oliver-sanders oliver-sanders self-assigned this Apr 6, 2023
This was referenced Apr 6, 2023
Closed
Merged
Closed
@oliver-sanders oliver-sanders force-pushed the cat-log-workflow-file-option branch 2 times, most recently from 8c09b9a to 0a41a01 Compare April 6, 2023 12:55
oliver-sanders
oliver-sanders commented Apr 6, 2023
View reviewed changes
CHANGES.md Outdated Show resolved Hide resolved
oliver-sanders
oliver-sanders commented Apr 6, 2023
View reviewed changes
CHANGES.md Outdated Show resolved Hide resolved
@oliver-sanders oliver-sanders marked this pull request as ready for review April 13, 2023 17:05
@oliver-sanders
Copy link
Member Author

Rebasing onto 8.1.x to allow this work to be released before the Vue3 upgrade.

For safekeeping the 8.1.x branch can be found here: https://github.com/oliver-sanders/cylc-flow/pull/new/cat-log-workflow-file-option-8.2

@oliver-sanders oliver-sanders modified the milestones: cylc-8.2.0, cylc-8.1.3 Apr 18, 2023
@oliver-sanders oliver-sanders changed the base branch from master to 8.1.x April 18, 2023 12:29
@oliver-sanders
Copy link
Member Author

(re-opened to kick-ci into action)

oliver-sanders added a commit to oliver-sanders/cylc-uiserver that referenced this pull request Apr 18, 2023
@oliver-sanders
setup: bump cylc-flow pin
c2fdf9f 
* cylc#439 requires
  cylc/cylc-flow#5453 added in
  cylc-flow 8.1.3
@oliver-sanders oliver-sanders mentioned this pull request Apr 18, 2023
Merged
8 tasks
hjoliver
hjoliver approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM; tested with sibling PRs.

cylc/flow/scripts/cat_log.py Outdated Show resolved Hide resolved
@wxtim
Copy link
Member

wxtim commented Apr 19, 2023

I kicked the functional tests- I have the two failing cylc-cat-log tests running OK locally, but the third, cylc-clean/06... fails locally on this branch.

@datamel @oliver-sanders
cat-log: support other workflow files
8cc4fc3 
* Update cat log to request specific workflow log file with -f option
@oliver-sanders oliver-sanders force-pushed the cat-log-workflow-file-option branch 3 times, most recently from cca4417 to dd8cfff Compare April 19, 2023 14:43
@oliver-sanders
cat-log: change interface for scheduler logs to include the dirname
e01ce1b 
* Support specifying the job submit number in the ID.
* Support specifying the most recent workflow log file via a
  one letter filename as with job logs.
* Add --prepend-path option which print the host:filepath before
  cat or tail operations. This is used by the UI to display the
  host:path where the log file is located.
oliver-sanders added a commit to oliver-sanders/cylc-uiserver that referenced this pull request Apr 20, 2023
@oliver-sanders
setup: bump cylc-flow pin
2f7cd71 
* cylc#439 requires
  cylc/cylc-flow#5453 added in
  cylc-flow 8.1.3
@wxtim wxtim merged commit e356317 into cylc:8.1.x Apr 21, 2023
@oliver-sanders oliver-sanders deleted the cat-log-workflow-file-option branch April 21, 2023 10:02
This was referenced Apr 24, 2023
Closed
Merged
@oliver-sanders oliver-sanders mentioned this pull request May 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxtim wxtim wxtim approved these changes

@hjoliver hjoliver hjoliver approved these changes

Assignees

@oliver-sanders oliver-sanders

Labels
None yet
Projects
None yet
Milestone
cylc-8.1.3
Development

Successfully merging this pull request may close these issues.
4 participants
@oliver-sanders @wxtim @hjoliver @datamel