Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tokens: speed up duplication of Tokens objects #5325

Merged
merged 6 commits into from
Jan 25, 2023
Merged

tokens: speed up duplication of Tokens objects #5325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift click to select a range
2219798
tokens: speed up duplication of Tokens objects
oliver-sanders Jan 24, 2023
d516c48
Update cylc/flow/id.py
oliver-sanders Jan 24, 2023
c84aa80
tests/i: fix id type
oliver-sanders Jan 25, 2023
2605d85
changelog
oliver-sanders Jan 25, 2023
94b3bc5
Merge branch '8.1.x' into tokens-duplicate
oliver-sanders Jan 25, 2023
c03ed4c
Merge branch '8.1.x' into tokens-duplicate
MetRonnie Jan 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 20,13 @@ ones in. -->
[#5314](https://github.com/cylc/cylc-flow/pull/5314) - Fix broken
command option: `cylc vip --run-name`.

[#5319](https://github.com/cylc/cylc-flow/pull/5319),
[#5321](https://github.com/cylc/cylc-flow/pull/5321),
[#5325](https://github.com/cylc/cylc-flow/pull/5325) -
Various efficiency optimisations to the scheduler which particularly impact
workflows with many-to-many dependencies (e.g. `<a> => <b>`).

-------------------------------------------------------------------------------
## __cylc-8.1.0 (<span actions:bind='release-date'>Released 2023-01-16</span>)__

### Breaking Changes
Expand Down
5 changes: 4 additions & 1 deletion cylc/flow/id.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 107,10 @@ def __init__(
if args:
if len(args) > 1:
raise ValueError()
kwargs = tokenise(str(args[0]), relative)
if isinstance(args[0], str):
kwargs = tokenise(args[0], relative)
else:
kwargs = dict(args[0])
else:
for key in kwargs:
if key not in self._KEYS:
Expand Down
2 changes: 1 addition & 1 deletion tests/integration/test_reinstall.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 80,7 @@ def one_run(one_src, test_dir, run_dir):
)
return SimpleNamespace(
path=w_run_dir,
id=w_run_dir.relative_to(run_dir),
id=str(w_run_dir.relative_to(run_dir)),
)


Expand Down