-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert old clock triggers to wall_clock xtriggers. #5291
Conversation
956f66e
to
e6f584c
Compare
Two functional tests deleted because they only tested |
That was quick! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, tested as working.
|
||
Clock-trigger tasks (see :ref:`ClockTriggerTasks`) wait on a wall | ||
Clock-triggered tasks (see :ref:`ClockTriggerTasks`) wait on a wall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might want to remove the ClockTriggerTasks
section of the docs along with this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (just codecov falling over as is its wont)
Co-authored-by: Oliver Sanders <[email protected]>
Close #5285
Check List
CONTRIBUTING.md
and added my name as a Code Contributor.setup.cfg
andconda-environment.yml
.CHANGES.md
entry included if this is a change that can affect users?.?.x
branch.Covered by existing tests: