-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workflow-state command back compat. #5237
Conversation
d37bc5e
to
58ac31c
Compare
Codecov patch fail is because I'm not testing the |
Re-based to 8.2.x. It's arguably a bug fix, and needed ASAP at NIWA. |
Co-authored-by: Ronnie Dutta <61982285 [email protected]>
154ede5
to
5afeb39
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but haven't tested
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me 👍
(I would have to build an older VM or use work machines to test)
The sibling is probably equally important (as some cylc8 workflows may be upstream of cylc7 on migration). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok managed to test out but it's not working. And the error message only shows up in --debug
DEBUG - [xtrigger-func cmd] cylc function-run workflow_state '[]' '{"workflow": "cylc7-complex", "task": "brief_wagtail_forecast_landsim", "point": "20150219T0000Z"}' ~/cylc-
run/workflow-state
[xtrigger-func ret_code] 1
[xtrigger-func err]
Traceback (most recent call last):
File "~/.conda/envs/cylc8/bin/cylc", line 8, in <module>
sys.exit(main())
File "~/cylc-flow/cylc/flow/scripts/cylc.py", line 660, in main
execute_cmd(command, *cmd_args)
File "~/cylc-flow/cylc/flow/scripts/cylc.py", line 286, in execute_cmd
entry_point.resolve()(*args)
File "~/cylc-flow/cylc/flow/scripts/function_run.py", line 41, in main
run_function(args[1], args[2], args[3], args[4])
File "~/cylc-flow/cylc/flow/subprocpool.py", line 115, in run_function
res = func(*func_args, **func_kwargs)
File "~/cylc-flow/cylc/flow/xtriggers/workflow_state.py", line 93, in workflow_state
fmt = checker.get_remote_point_format()
File "~/cylc-flow/cylc/flow/dbstatecheck.py", line 80, in get_remote_point_format
for row in self.conn.execute(
sqlite3.OperationalError: no such table: workflow_params
[scheduling]
[[graph]]
R1 = @upstream => foo
[[xtriggers]]
upstream = workflow_state(workflow=cylc7-complex, task=brief_wagtail_forecast_landsim, point=20150219T0000Z)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've pushed a fix. May be sensible to add a functional test with a minimal Cylc 7 workflow DB, I can have a look at doing this if you're short on time
Argh, last minute non-careful function name change by me, damn it. Thanks for the fix. |
@hjoliver Do you want to merge if happy with the test I've added |
Yes, very happy - thanks @MetRonnie |
Address #5236
Sibling of #5238
Check List
CONTRIBUTING.md
and added my name as a Code Contributor.setup.cfg
andconda-environment.yml
.CHANGES.md
entry included if this is a change that can affect users?.?.x
branch.