Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data-store prune of optional discontinued branch #4976

Merged
merged 1 commit into from
Jul 20, 2022
Merged

Data-store prune of optional discontinued branch #4976

merged 1 commit into from
Jul 20, 2022

Conversation

dwsutherland
Copy link
Member

@dwsutherland dwsutherland commented Jul 8, 2022 •
edited
Loading

These changes close #4969

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg and conda-environment.yml.
  • Appropriate tests are included (unit and/or functional).
  • Appropriate change log entry included.
  • No documentation update required.

@dwsutherland dwsutherland added this to the cylc-8.0.0 milestone Jul 8, 2022
@dwsutherland dwsutherland self-assigned this Jul 8, 2022
@dwsutherland dwsutherland force-pushed the optional-discontinue-datastore-prune branch 6 times, most recently from c961540 to 77f815c Compare July 9, 2022 09:21
@hjoliver
Copy link
Member

Small conflict to fix.

@dwsutherland dwsutherland force-pushed the optional-discontinue-datastore-prune branch from 77f815c to 6160469 Compare July 18, 2022 23:56
@dwsutherland
Copy link
Member Author

Small conflict to fix.

fixed. and the test sleep.

hjoliver
hjoliver approved these changes Jul 19, 2022
View reviewed changes
Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dwsutherland 🎉

@hjoliver
Copy link
Member

This is a very small code change, it definitely fixes the problem, and tests pass. Under current circumstances (8.0 release is looming fast)... one review will do.

@hjoliver hjoliver merged commit db08c0b into cylc:master Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjoliver hjoliver hjoliver approved these changes

Assignees

@dwsutherland dwsutherland

Labels
small
Projects
None yet
Milestone
cylc-8.0.0
Development

Successfully merging this pull request may close these issues.

datastore: failed tasks not cleaned up
2 participants
@dwsutherland @hjoliver