-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean other remotes after error. #4950
Conversation
997c8f3
to
b7dc0e6
Compare
I don't think #4935 is much of an issue (at least not much of an 8.0.0 issue) so happy with whatever. (the "broken platform" issue mostly impacts developers and if |
LGTM; just needs a test. |
I agree it's a small issue. #4949 is more important, and this sort of caused that (i.e., a remote clean failure in one workflow prevented cleaning of a bunch of others at the same time). However, it still a bug (cleaning a valid remote should not depend on whether or not we try to clean an invalid one first) and easy to fix. |
However, as this one is not very important and it's not instantly clear to me how to test it, I'll bump it back to 8.x |
Been draft for a while! In the mean time this functionality has been implemented as part of other work. Remote cleans are now performed in parallel with any errors reported at the end, so one failed remote clean no longer blocks others. |
These changes close #4935
If
cylc clean
fails to clean a remote platform, continue on to other remote platforms but do not clean locally.@oliver-sanders - you've suggested going further than this #4935 (comment) - but I think that's a potential follow-up. This quick-fix will be a significant improvement as-is - OK?
Requirements check-list
CONTRIBUTING.md
and added my name as a Code Contributor.setup.cfg
andconda-environment.yml
.