Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix data-store DB job load #4891

Merged
merged 2 commits into from
Jun 1, 2022
Merged

Fix data-store DB job load #4891

merged 2 commits into from
Jun 1, 2022

Conversation

dwsutherland
Copy link
Member

@dwsutherland dwsutherland commented May 20, 2022 •
edited
Loading

These changes close #4784

For example, with triggering an historical task:

$ cylc trigger linear //20210801T00/qux

Before
(only one job loaded from DB)
image

After
image

Also with the window about a historical task:

$ cylc trigger linear //20210801T00/qaz

After
image

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg and conda-environment.yml.
  • Test added to cover DB load of jobs on restart.
  • Appropriate change log entry included.
  • No documentation update required.

@dwsutherland dwsutherland added this to the cylc-8.0rc4 milestone May 20, 2022
@dwsutherland dwsutherland self-assigned this May 20, 2022
@MetRonnie MetRonnie self-requested a review May 20, 2022 11:05
@MetRonnie MetRonnie added the bug Something is wrong :( label May 20, 2022
@dwsutherland dwsutherland mentioned this pull request May 23, 2022
Closed
@dwsutherland
Copy link
Member Author

have to figure out another couple of issues:

  • when restarting under certain circumstances the job history is not there
  • when restarted with historical job failures the state is incorrect..

Looking into it now..

@dwsutherland
Copy link
Member Author

have to figure out another couple of issues:

  • when restarting under certain circumstances the job history is not there
  • when restarted with historical job failures the state is incorrect..

Looking into it now..

Ok fixed.

MetRonnie
MetRonnie reviewed May 30, 2022
View reviewed changes
Copy link
Member

@MetRonnie MetRonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested out and seems to do the trick. Just a couple of niggles

CHANGES.md Outdated Show resolved Hide resolved
cylc/flow/rundb.py Show resolved Hide resolved
hjoliver
hjoliver approved these changes Jun 1, 2022
View reviewed changes
Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @dwsutherland 👍 Can be merged once you've addressed @MetRonnie 's comments.

@dwsutherland
Copy link
Member Author

LGTM @dwsutherland 👍 Can be merged once you've addressed @MetRonnie 's comments.

Addressed.

@MetRonnie MetRonnie merged commit 0c977d6 into cylc:master Jun 1, 2022
@hjoliver hjoliver modified the milestones: cylc-8.0rc4, cylc-8.0.0 Jul 5, 2022
@dwsutherland dwsutherland mentioned this pull request Jul 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MetRonnie MetRonnie MetRonnie approved these changes

@hjoliver hjoliver hjoliver approved these changes

@oliver-sanders oliver-sanders Awaiting requested review from oliver-sanders

Assignees

@dwsutherland dwsutherland

Labels
bug Something is wrong :( small
Projects
None yet
Milestone
cylc-8.0.0
Development

Successfully merging this pull request may close these issues.

data store: issues when reloading workflows
3 participants
@dwsutherland @hjoliver @MetRonnie